netdev - Re: [PATCH 20/22] fjes: epstop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5582CDD7.9030304@cogentembedded.com>
Date:	Thu, 18 Jun 2015 16:55:35 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Taku Izumi <izumi.taku@...fujitsu.com>,
	platform-driver-x86@...r.kernel.org, dvhart@...radead.org
CC:	rkhan@...hat.com, alexander.h.duyck@...hat.com,
	netdev@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 20/22] fjes: epstop_task

Hello.

On 6/18/2015 3:49 AM, Taku Izumi wrote:

> This patch adds epstop_task.
> This task is used to process other receiver's
> cancellation request.

> Signed-off-by: Taku Izumi <izumi.taku@...fujitsu.com>
> ---
>   drivers/platform/x86/fjes/fjes_hw.c   | 34 ++++++++++++++++++++++++++++++++++
>   drivers/platform/x86/fjes/fjes_hw.h   |  1 +
>   drivers/platform/x86/fjes/fjes_main.c |  1 +
>   3 files changed, 36 insertions(+)

> diff --git a/drivers/platform/x86/fjes/fjes_hw.c b/drivers/platform/x86/fjes/fjes_hw.c
> index e07b266..c22679a 100644
> --- a/drivers/platform/x86/fjes/fjes_hw.c
> +++ b/drivers/platform/x86/fjes/fjes_hw.c
[...]
> @@ -1123,3 +1126,34 @@ static void fjes_hw_update_zone_task(struct work_struct *work)
>   	}
>   }
>
> +static void fjes_hw_epstop_task(struct work_struct *work)
> +{
> +	struct fjes_hw *hw = container_of(work,
> +			struct fjes_hw, epstop_task);

    Please start the continuation lines under 'work' on the first line.

> +	struct fjes_adapter *adapter = (struct fjes_adapter *)hw->back;
> +	int epid_bit;
> +	unsigned long remain_bit;
> +
> +	while ((remain_bit = hw->epstop_req_bit)) {
> +

    Don't think this empty line is needed.

> +		for (epid_bit = 0; remain_bit; (remain_bit >>= 1),
> +			(epid_bit++)) {

    Inner parens not needed, the comma operator has lowest priority.

> +
> +			if (remain_bit & 1) {
> +

    Don't think this empty line is needed.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html