netdev - Re: [PATCH 12/22] fjes: net_device_ops.ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5582CF14.3040507@cogentembedded.com>
Date:	Thu, 18 Jun 2015 17:00:52 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Taku Izumi <izumi.taku@...fujitsu.com>,
	platform-driver-x86@...r.kernel.org, dvhart@...radead.org
CC:	rkhan@...hat.com, alexander.h.duyck@...hat.com,
	netdev@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 12/22] fjes: net_device_ops.ndo_get_stats64

Hello.

On 6/18/2015 3:49 AM, Taku Izumi wrote:

> This patch adds net_device_ops.ndo_get_stats64 callback.

> Signed-off-by: Taku Izumi <izumi.taku@...fujitsu.com>
> ---
>   drivers/platform/x86/fjes/fjes_main.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)

> diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platform/x86/fjes/fjes_main.c
> index 97bf487..eeda824 100644
> --- a/drivers/platform/x86/fjes/fjes_main.c
> +++ b/drivers/platform/x86/fjes/fjes_main.c
> @@ -57,6 +57,8 @@ static netdev_tx_t fjes_xmit_frame(struct sk_buff *,
>   static void fjes_raise_intr_rxdata_task(struct work_struct *);
>   static void fjes_tx_stall_task(struct work_struct *);
>   static irqreturn_t fjes_intr(int, void*);
> +static struct rtnl_link_stats64
> +*fjes_get_stats64(struct net_device *, struct rtnl_link_stats64 *);

    I'd leave * on the first line, otherwise it looks quite ugly..

[...]
> @@ -734,6 +737,17 @@ static netdev_tx_t fjes_xmit_frame(struct sk_buff *skb,
>   	return ret;
>   }
>
> +static struct rtnl_link_stats64
> +*fjes_get_stats64(struct net_device *netdev,

    Same here.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html