netdev - Re: [PATCH 1/1] ssb: remove unncessary out label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150619171311.7ed6dfd1@wiggum>
Date:	Fri, 19 Jun 2015 17:13:11 +0200
From:	Michael Büsch <m@...s.ch>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	pankaj.m@...sung.com
Subject: Re: [PATCH 1/1] ssb: remove unncessary out label

On Fri, 19 Jun 2015 14:23:45 +0530
Maninder Singh <maninder1.s@...sung.com> wrote:

> This patch removes unnecessary label "out" and
> some restructring for using device_create_file directly.
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Reviewed-by: Rohit Thapliyal <r.thapliyal@...sung.com>
> ---
>  drivers/ssb/pci.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index 0f28c08..d6ca4d3 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -1173,17 +1173,11 @@ void ssb_pci_exit(struct ssb_bus *bus)
>  int ssb_pci_init(struct ssb_bus *bus)
>  {
>  	struct pci_dev *pdev;
> -	int err;
>  
>  	if (bus->bustype != SSB_BUSTYPE_PCI)
>  		return 0;
>  
>  	pdev = bus->host_pci;
>  	mutex_init(&bus->sprom_mutex);
> -	err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
> -	if (err)
> -		goto out;
> -
> -out:
> -	return err;
> +	return device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
>  }


I don't really think this change adds any value, but if you insist on
it you get my acked-by.


-- 
Michael

Content of type "application/pgp-signature" skipped