netdev - Re: [PATCH 2/3] rcar_can: print signed IRQ #

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWZFKR04NJc7xtnPUosYuosX9FPDJopG3wovu_GqGxSOw@mail.gmail.com>
Date:	Sat, 20 Jun 2015 14:03:04 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	wg@...ndegger.com, Marc Kleine-Budde <mkl@...gutronix.de>,
	linux-can@...r.kernel.org, Linux-sh list <linux-sh@...r.kernel.org>
Subject: Re: [PATCH 2/3] rcar_can: print signed IRQ #

Hi Sergei,

On Sat, Jun 20, 2015 at 2:33 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Printing IRQ # using "%x" and "%u" unsigned formats isn't quite correct as
> 'ndev->irq' is of  type *int*, so  the "%d" format  needs to be used instead.
>
> While fixing this, beautify the dev_info() message in rcar_can_probe() a bit.

If you change the message, why don't you make it consistent
("interrupt" vs. "IRQ")?

> Fixes: fd1159318e55 ("can: add Renesas R-Car CAN driver")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>
> ---
>  drivers/net/can/rcar_can.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-can/drivers/net/can/rcar_can.c
> ===================================================================
> --- linux-can.orig/drivers/net/can/rcar_can.c
> +++ linux-can/drivers/net/can/rcar_can.c
> @@ -526,7 +526,7 @@ static int rcar_can_open(struct net_devi
>         napi_enable(&priv->napi);
>         err = request_irq(ndev->irq, rcar_can_interrupt, 0, ndev->name, ndev);
>         if (err) {
> -               netdev_err(ndev, "error requesting interrupt %x\n", ndev->irq);
> +               netdev_err(ndev, "error requesting interrupt %d\n", ndev->irq);
>                 goto out_close;
>         }
>         can_led_event(ndev, CAN_LED_EVENT_OPEN);
> @@ -824,7 +824,7 @@ static int rcar_can_probe(struct platfor
>
>         devm_can_led_init(ndev);
>
> -       dev_info(&pdev->dev, "device registered (reg_base=%p, irq=%u)\n",
> +       dev_info(&pdev->dev, "device registered (regs @ %p, IRQ%d)\n",
>                  priv->regs, ndev->irq);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in