netdev - Re: [PATCH v5] NET: Add ezchip ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150621.092218.2158342160706463595.davem@davemloft.net>
Date:	Sun, 21 Jun 2015 09:22:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	noamc@...hip.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexey.Brodkin@...opsys.com, vgupta@...opsys.com,
	giladb@...hip.com, cmetcalf@...hip.com, talz@...hip.com
Subject: Re: [PATCH v5] NET: Add ezchip ethernet driver

From: Noam Camus <noamc@...hip.com>
Date: Tue, 16 Jun 2015 17:35:42 +0300

> From: Noam Camus <noamc@...hip.com>
> 
> Simple LAN device for debug or management purposes.
> Device supports interrupts for RX and TX(completion).
> Device does not have DMA ability.
> 
> Signed-off-by: Noam Camus <noamc@...hip.com>
> Signed-off-by: Tal Zilcer <talz@...hip.com>
> Acked-by: Alexey Brodkin <abrodkin@...opsys.com>

This builds with several warnings and also doesn't compile.

drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_read_rx_fifo’:
drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_send_frame’:
drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_poll_controller’:
drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declaration of function ‘nps_enet_board_irq_handler’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

I do not even see where npe_enet_board_irq_handler could possible be defined.

It is quite infuriating to receive a patch like this which is claimed
to be complete and ready to be applied to my tree, yet it is very
clearly not.