lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150621.102144.267706734504980452.davem@davemloft.net>
Date:	Sun, 21 Jun 2015 10:21:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	netdev@...r.kernel.org, amirv@...lanox.com, talal@...lanox.com,
	achiad@...lanox.com, saeedm@...lanox.com
Subject: Re: [PATCH net-next 05/12] net/mlx5e: Poll rx cq before tx cq to
 improve round-trip latency

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Wed, 17 Jun 2015 18:26:22 +0300

> From: Achiad Shochat <achiad@...lanox.com>
> 
> For better round trip latency, handle rx completions before
> tx completions.
> 
> Signed-off-by: Achiad Shochat <achiad@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>

I completely disagree with this change.

TX completions should always be handled first because they free up resources
and therefore increase the likelyhood that RX processing will not fail due
to lack of resources (memory, etc.).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ