netdev - Re: [PATCHv2 net-next] net: fec: Ensure clocks are enabled while using mdio bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 21 Jun 2015 22:15:02 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Nimrod Andy <B38611@...escale.com>,
	Duan Andy <fugang.duan@...escale.com>,
	Cory Tusar <cory.tusar@...1solutions.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCHv2 net-next] net: fec: Ensure clocks are enabled while
 using mdio bus

On Sat, Jun 20, 2015 at 06:01:33PM -0700, Florian Fainelli wrote:
> Le 06/20/15 09:15, Andrew Lunn a écrit :
> > When a switch is attached to the mdio bus, the mdio bus can be used
> > while the interface is not open. If the IPG clock are not enabled,
> > MDIO reads/writes will simply time out. So enable the clock before
> > starting a transaction, and disable it afterwards. The CCF performs
> > reference counting so the clock will only be disabled if there are no
> > other users.
> > 
> > Signed-off-by: Andrew Lunn <andrew@...n.ch>
> > ---
> > v2:
> >   Only enable/disable the IPG clock.
> > 
> > drivers/net/ethernet/freescale/fec_main.c | 21 +++++++++++++++++++--
> >  1 file changed, 19 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> > index bf4cf3fbb5f2..2b8a043a573c 100644
> > --- a/drivers/net/ethernet/freescale/fec_main.c
> > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > @@ -65,6 +65,7 @@
> >  
> >  static void set_multicast_list(struct net_device *ndev);
> >  static void fec_enet_itr_coal_init(struct net_device *ndev);
> > +static int fec_enet_clk_enable(struct net_device *ndev, bool enable);
> 
> You do not seem to be using this, unrelated change?

Hi Florian

Left over from v1, where i did call this function to enable/disable
the clocks. It can be removed now that i use the common clock
framework directly to enable only a single clock.

	  Andrew
--
To unsubscribe from this list: send the line "unsubscribe netdev" in