netdev - Re: [PATCH] net: inet_diag: export IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1434876777.31511.24.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sun, 21 Jun 2015 01:52:57 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Phil Sutter <phil@....cc>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH] net: inet_diag: export IPV6_V6ONLY sockopt

On Sun, 2015-06-21 at 03:47 +0200, Phil Sutter wrote:

> 
> > 1) This certainly should not compile on current linux trees.
> >    Always submit such patches on net-next.
> 
> It cleanly applies to net.git.

A very old one, because there is no ipv6only field anymore after
commit 9fe516ba3fb29b6f6a752ffd93342fdee500ec01 ("inet: move ipv6only in
sock_common") back in linux 3.17 

inet6_sk(sk)->ipv6only can not possibly compile today, I am pretty sure
of this.

# git grep -n ipv6only -- include
include/linux/ipv6.h:285:#define __ipv6_only_sock(sk)   (sk->sk_ipv6only)
include/linux/ipv6.h:297:static inline int inet_v6_ipv6only(const struct sock *sk)
include/linux/ipv6.h:299:       /* ipv6only field is at same position for timewait and other sockets */
include/linux/ipv6.h:324:#define tcp_twsk_ipv6only(__sk)                0
include/linux/ipv6.h:325:#define inet_v6_ipv6only(__sk)         0
include/net/inet_timewait_sock.h:58:#define tw_ipv6only         __tw_common.skc_ipv6only
include/net/sock.h:186: unsigned char           skc_ipv6only:1;
include/net/sock.h:325:#define sk_ipv6only              __sk_common.skc_ipv6only

So always make sure your tree is not one year old before submitting a patch.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in