netdev - Re: [PATCH 1/1] ssb: remove unncessary out label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 22 Jun 2015 03:47:39 +0000 (GMT)
From:	Maninder Singh <maninder1.s@...sung.com>
To:	Michael B?ch <m@...s.ch>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	PANKAJ MISHRA <pankaj.m@...sung.com>
Subject: Re: [PATCH 1/1] ssb: remove unncessary out label

Hi Michael,

>>  	pdev = bus->host_pci;
>>  	mutex_init(&bus->sprom_mutex);
>> -	err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
>> -	if (err)
>> -		goto out;
>> -
>> -out:
>> -	return err;
>> +	return device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
>>  }
>
>
>I don't really think this change adds any value, but if you insist on
>it you get my acked-by.

Yes You are right, But By this change code looks simpler.
Thats why i suggested the changes.

Thanks
Maninder