netdev - Re: [PATCH net-next 2/2 v6] net: ipv4 sysctl option to ignore routes when nexthop link is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150623172028.GT588@gospo.home.greyhouse.net>
Date:	Tue, 23 Jun 2015 13:20:33 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	Scott Feldman <sfeldma@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>, ddutt@...ulusnetworks.com,
	Alexander Duyck <alexander.duyck@...il.com>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>
Subject: Re: [PATCH net-next 2/2 v6] net: ipv4 sysctl option to ignore routes
 when nexthop link is down

On Tue, Jun 23, 2015 at 09:30:15AM -0700, Scott Feldman wrote:
> On Tue, Jun 23, 2015 at 8:51 AM, Andy Gospodarek
> <gospo@...ulusnetworks.com> wrote:
> > This feature is only enabled with the new per-interface or ipv4 global
> > sysctls called 'ignore_routes_with_linkdown'.
> 
> [cut]
> 
> checkpatch.pl says:
> 
> WARNING: suspect code indent for conditional statements (16, 20)
> #293: FILE: net/ipv4/fib_semantics.c:1047:
> +               if (fi->fib_nh->nh_flags & RTNH_F_LINKDOWN) {
> +                   in_dev = __in_dev_get_rcu(fi->fib_nh->nh_dev);

Good catch, Scott.  I saw this one, but mistakenly looked at the lines
around it and thought I was following the style in the file.  v7 coming
soon.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html