netdev - Re: [PATCH net-next V11 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5589AD11.1060009@gmail.com>
Date:	Tue, 23 Jun 2015 15:01:37 -0400
From:	Thomas F Herbert <thomasfherbert@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	netdev@...r.kernel.org, pshelar@...ira.com
CC:	therbert@...hat.com, dev@...nvswitch.org
Subject: Re: [PATCH net-next V11 2/3] Check for vlan ethernet types for 8021.q
 or 802.1ad

On 6/23/15 2:43 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 06/23/2015 09:26 PM, Thomas F Herbert wrote:
>
>> Signed-off-by: Thomas F Herbert <thomasfherbert@...il.com>
> [...]
>
>> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
>> index 920e445..3713454 100644
>> --- a/include/linux/if_vlan.h
>> +++ b/include/linux/if_vlan.h
>> @@ -627,5 +627,14 @@ static inline netdev_features_t
>> vlan_features_check(const struct sk_buff *skb,
>>
>>       return features;
>>   }
>> +/**
>> + * Check for legal valid vlan ether type.
>
>     The comment doesn't follow the kernel-doc format determined by /**.
OK, I will change it to the proper kernel doc format.
>
>> + */
>> +static inline bool eth_type_vlan(__be16 ethertype)
>> +{
>> +    if (ethertype == htons(ETH_P_8021Q) || ethertype ==
>> htons(ETH_P_8021AD))
>> +        return true;
>> +    return false;
>
>     Perhaps *switch*?
I have no objection to changing this to a switch statement.
>
> [...]
>
> WBR, Sergei
>


-- 
Thomas F. Herbert
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html