netdev - Re: [PATCH net-next 1/3 v5] net: track link-status of ipv4 nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150623.023040.2256044180311272935.davem@davemloft.net>
Date:	Tue, 23 Jun 2015 02:30:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gospo@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, ddutt@...ulusnetworks.com,
	sfeldma@...il.com, alexander.duyck@...il.com,
	hannes@...essinduktion.org, stephen@...workplumber.org
Subject: Re: [PATCH net-next 1/3 v5] net: track link-status of ipv4 nexthops

From: Andy Gospodarek <gospo@...ulusnetworks.com>
Date: Thu, 18 Jun 2015 11:22:10 -0400

> -		    ((nh->nh_flags ^ onh->nh_flags) & ~RTNH_F_DEAD))
> +		    ((nh->nh_flags ^ onh->nh_flags) & ~(RTNH_F_COMPARE_MASK)))
>  			return -1;

Excessive parenthesis, just plain "~RTNH_F_COMPARE_MASK" is sufficient.

> +		if (linkdown == fi->fib_nhs) {
> +			fi->fib_flags |= RTNH_F_LINKDOWN;
> +		}

Single line basic blocks do not get enclosing curly braces.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html