netdev - Re: [PATCH] xen-netback: fix a BUG() during initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150623.033436.27435944821901354.davem@davemloft.net>
Date:	Tue, 23 Jun 2015 03:34:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	imrep.amz@...il.com
Cc:	xen-devel@...ts.xenproject.org, ian.campbell@...rix.com,
	wei.liu2@...rix.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, imrep@...zon.de, msw@...zon.com
Subject: Re: [PATCH] xen-netback: fix a BUG() during initialization

From: Imre Palik <imrep.amz@...il.com>
Date: Fri, 19 Jun 2015 14:21:51 +0200

> From: "Palik, Imre" <imrep@...zon.de>
> 
> Commit edafc132baac ("xen-netback: making the bandwidth limiter runtime settable")
> introduced the capability to change the bandwidth rate limit at runtime.
> But it also introduced a possible crashing bug.
> 
> If netback receives two XenbusStateConnected without getting the
> hotplug-status watch firing in between, then it will try to register the
> watches for the rate limiter again.  But this triggers a BUG() in the watch
> registration code.
> 
> The fix modifies connect() to remove the possibly existing packet-rate
> watches before trying to install those watches.  This behaviour is in line
> with how connect() deals with the hotplug-status watch.
> 
> Signed-off-by: Imre Palik <imrep@...zon.de>
> Cc: Matt Wilson <msw@...zon.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html