netdev - Re: [PATCH] net: dsa: mv88e6xxx: split phy page accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150623.061825.2036705332261161582.davem@davemloft.net>
Date:	Tue, 23 Jun 2015 06:18:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vivien.didelot@...oirfairelinux.com
Cc:	netdev@...r.kernel.org, andrew@...n.ch, linux@...ck-us.net,
	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com
Subject: Re: [PATCH] net: dsa: mv88e6xxx: split phy page accessors

From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Date: Fri, 19 Jun 2015 10:32:10 -0400

> Split mv88e6xxx_phy_page_read and mv88e6xxx_phy_page_write into two
> functions each, one to acquire the smi_mutex and one to call the actual
> read/write functions.
> 
> This will be useful to access registers such as Fiber/SERDES Control,
> from setup code with SMI lock held.
> 
> Also rename their "error" labels to "clear", since it is not only an
> error path.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Please resubmit this alongside a patch that actually uses the new
facility.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html