netdev - Re: [PATCH v2 1/1] net: fs_enet: Fix NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Jun 2015 06:39:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	alex.popov@...ux.com
Cc:	pantelis.antoniou@...il.com, vbordug@...mvista.com,
	christophe.leroy@....fr, linuxppc-dev@...ts.ozlabs.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] net: fs_enet: Fix NETIF_F_SG feature for
 Freescale MPC5121

From: Alexander Popov <alex.popov@...ux.com>
Date: Sun, 21 Jun 2015 01:32:46 +0300

> Commit 4fc9b87bae25 ("net: fs_enet: Implement NETIF_F_SG feature")
> brings a trouble to Freescale MPC512x: a kernel oops happens
> during sending non-linear sk_buff with .data not aligned by 4.
> 
> Log quotation:
 ...
> The reason:
> 
> MPC5121 FEC requires 4-byte alignment for TX data buffer and calls
> tx_skb_align_workaround() for copying sk_buff with not aligned .data to a new
> sk_buff with aligned one. But tx_skb_align_workaround() uses
> skb_copy_from_linear_data() which doesn't work for non-linear sk_buff:
> a new sk_buff has non-zero nr_frags and zero .data_len.
> 
> So improve the condition of calling tx_skb_align_workaround() and use
> skb_linearize() in it.
> 
> Signed-off-by: Alexander Popov <alex.popov@...ux.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html