netdev - Re: [PATCH v2] net: Cavium: Fix MAC address setting in shutdown state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150623.071013.2258233138502834064.davem@davemloft.net>
Date:	Tue, 23 Jun 2015 07:10:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	p.fedin@...sung.com
Cc:	netdev@...r.kernel.org, Aleksey.Makarov@...iumnetworks.com,
	sgoutham@...ium.com, thlab.kim@...sung.com, s.dyasly@...sung.com,
	robert.richter@...iumnetworks.com
Subject: Re: [PATCH v2] net: Cavium: Fix MAC address setting in shutdown
 state

From: Pavel Fedin <p.fedin@...sung.com>
Date: Tue, 23 Jun 2015 10:11:03 +0300

> This bug pops up with NetworkManager on Fedora 21. NetworkManager tends to
> stop the interface (nicvf_stop() is called) before changing settings. In
> stopped state MAC cannot be sent to a PF. However, when the interface is
> restarted (nicvf_open() is called), we ping the PF using NIC_MBOX_MSG_READY
> message, and the PF replies back with old MAC address, overriding what we
> had after MAC setting from userspace. As a result, we cannot set MAC
> address using NetworkManager.
> 
> This patch introduces special tracking of MAC change in stopped state so
> that the correct new MAC address is sent to a PF when interface is reopen.
> 
> Signed-off-by: Pavel Fedin <p.fedin@...sung.com>
> ---
>  Differences from v1:
> - Fixed a couple of checkpatch.pl reports (was forgotten in v1)
> - Adjusted email client prefs, hopefully will not corrupt patches any more.

Still have problems:

> diff --git a/drivers/net/ethernet/cavium/thunder/nic.h b/drivers/net/ethernet/cavium/thunder/nic.h
> index a3b43e5..dda8a02 100755
> --- a/drivers/net/ethernet/cavium/thunder/nic.h
> +++ b/drivers/net/ethernet/cavium/thunder/nic.h
> @@ -263,6 +263,7 @@ struct nicvf {

This hunk makes 'git am' complain:

Applying: net: Cavium: Fix MAC address setting in shutdown state
warning: drivers/net/ethernet/cavium/thunder/nic.h has type 100644, expected 100755
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html