netdev - Re: [PATCH net 3/4] net/mlx4_en: Fix wrong csum complete report when rxvlan offload is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1435183281.4110.24.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 25 Jun 2015 00:01:21 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Amir Vadai <amirv@...lanox.com>, Ido Shamay <idos@...lanox.com>
Subject: Re: [PATCH net 3/4] net/mlx4_en: Fix wrong csum complete report
 when rxvlan offload is disabled

On Wed, 2015-06-24 at 18:22 +0300, Or Gerlitz wrote:
> From: Ido Shamay <idos@...lanox.com>
> 

> +	if (be32_to_cpu(cqe->vlan_my_qpn) & MLX4_CQE_VLAN_PRESENT_MASK &&
> +	    !(dev_features & NETIF_F_HW_VLAN_CTAG_RX)) {
>  		hw_checksum = get_fixed_vlan_csum(hw_checksum, hdr);
>  		hdr += sizeof(struct vlan_hdr);

This is faster to use 

if (cqe->vlan_my_qpn & cpu_to_be32(MLX4_CQE_VLAN_PRESENT_MASK) &&



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html