lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 24 Jun 2015 15:41:13 +0200
From:	Jesper Dangaard Brouer <brouer@...hat.com>
To:	Taku Izumi <izumi.taku@...fujitsu.com>
Cc:	brouer@...hat.com, netdev@...r.kernel.org,
	platform-driver-x86@...r.kernel.org, dvhart@...radead.org,
	rkhan@...hat.com, alexander.h.duyck@...hat.com,
	linux-acpi@...r.kernel.org, joe@...ches.com, yasu.isimatu@...il.com
Subject: Re: [PATCH v2 00/22] FUJITSU Extended Socket network device driver

On Wed, 24 Jun 2015 11:52:31 +0900
Taku Izumi <izumi.taku@...fujitsu.com> wrote:

> This patchsets adds FUJITSU Extended Socket network device driver.
> Extended Socket network device is a shared memory based high-speed network
> interface between Extended Partitions of PRIMEQUEST 2000 E2 series.
> 
> You can get some information about Extended Partition and Extended
> Socket by referring the following manual.
> 
> http://globalsp.ts.fujitsu.com/dmsp/Publications/public/CA92344-0537.pdf
>   3.2.1 Extended Partitioning
>   3.2.2 Extended Socket
> 
> v1 -> v2:
>   - Location change
>     drivers/platform/x86 => driver/net

Could/should this driver be placed under driver/net/ethernet/fujitsu ??

You are using Ethernet addresses but they are kind of special, always
02:00:00:00:00:xx which is hard-coded... maybe I misunderstand the
code/hw and it is not Ethernet?

[...]
>  drivers/net/fjes/Makefile       |   31 +
>  drivers/net/fjes/fjes.h         |   77 +++
>  drivers/net/fjes/fjes_ethtool.c |  135 ++++
>  drivers/net/fjes/fjes_hw.c      | 1122 +++++++++++++++++++++++++++++++
>  drivers/net/fjes/fjes_hw.h      |  333 ++++++++++
>  drivers/net/fjes/fjes_main.c    | 1397 +++++++++++++++++++++++++++++++++++++++
>  drivers/net/fjes/fjes_regs.h    |  142 ++++
>  9 files changed, 3246 insertions(+)
>  create mode 100644 drivers/net/fjes/Makefile
>  create mode 100644 drivers/net/fjes/fjes.h
>  create mode 100644 drivers/net/fjes/fjes_ethtool.c
>  create mode 100644 drivers/net/fjes/fjes_hw.c
>  create mode 100644 drivers/net/fjes/fjes_hw.h
>  create mode 100644 drivers/net/fjes/fjes_main.c
>  create mode 100644 drivers/net/fjes/fjes_regs.h
> 



-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ