netdev - Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Jun 2015 11:55:08 +0200
From:	Oliver Neukum <oneukum@...e.com>
To:	Enrico Mioso <mrkiko.rs@...il.com>
Cc:	linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

On Tue, 2015-06-23 at 00:32 +0200, Enrico Mioso wrote:

> +/* XXX rewrite, not multipacket */

Can you explain what you want to do here?
> +struct sk_buff *
> +huawei_ncm_tx_fixup(struct usbnet *dev, struct sk_buff *skb_in, gfp_t flags) {
> +	struct huawei_cdc_ncm_state *drvstate = (void *)&dev->data;
> +	struct cdc_ncm_ctx *ctx = drvstate->ctx;
> +	struct sk_buff *skb_out;
> +	int status;
> +
> +	skb_out = alloc_skb(ctx->tx_max, GFP_ATOMIC);

You must test this for NULL

	Regards
		Oliver



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html