netdev - Re: [PATCH iproute2] ss: Correct state 'listen' to 'listening' in docs and command help

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150624232828.7f05225c@uryu.home.lan>
Date:	Wed, 24 Jun 2015 23:28:28 -0400
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	"Brian Dyson" <brian.dyson@....net>
Cc:	<netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] ss: Correct state 'listen' to 'listening' in
 docs and command help

On Tue, 9 Jun 2015 19:49:01 -0700
"Brian Dyson" <brian.dyson@....net> wrote:

> Minor change to correct states in ss command documentation and command line
> help.
> The correct state term is 'listening' not 'listen' (see definition of
> sstate_namel in misc/ss.c).
> 
> Signed-off-by: Brian Dyson <brian.dyson@....net>
> ---
>  doc/ss.sgml   | 4 ++--
>  man/man8/ss.8 | 4 ++--
>  misc/ss.c     | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/doc/ss.sgml b/doc/ss.sgml
> index 3024b57..de168f7 100644
> --- a/doc/ss.sgml
> +++ b/doc/ss.sgml
> @@ -371,10 +371,10 @@ Available identifiers are:
>  <itemize>
>  <item> All standard TCP states: <tt/established/, <tt/syn-sent/,
>  <tt/syn-recv/, <tt/fin-wait-1/, <tt/fin-wait-2/, <tt/time-wait/,
> -<tt/closed/, <tt/close-wait/, <tt/last-ack/, <tt/listen/ and <tt/closing/.
> +<tt/closed/, <tt/close-wait/, <tt/last-ack/, <tt/listening/ and
> <tt/closing/.
> 
>  <item><tt/all/ - for all the states
> -<item><tt/connected/ - all the states except for <tt/listen/ and
> <tt/closed/
> +<item><tt/connected/ - all the states except for <tt/listening/ and
> <tt/closed/
>  <item><tt/synchronized/ - all the <tt/connected/ states except for
>  <tt/syn-sent/
>  <item><tt/bucket/ - states, which are maintained as minisockets, i.e.
> diff --git a/man/man8/ss.8 b/man/man8/ss.8
> index b7fbaef..4978eff 100644
> --- a/man/man8/ss.8
> +++ b/man/man8/ss.8
> @@ -142,14 +142,14 @@ Available identifiers are:
> 
>  All standard TCP states:
>  .BR established ", " syn-sent ", " syn-recv ", " fin-wait-1 ", " fin-wait-2
> ", " time-wait ", " closed ", " close-wait ", " last-ack ", "
> -.BR  listen " and " closing.
> +.BR  listening " and " closing.
> 
>  .B all
>  - for all the states
> 
>  .B connected
>  - all the states except for
> -.BR listen " and " closed
> +.BR listening " and " closed
> 
>  .B synchronized
>  - all the
> diff --git a/misc/ss.c b/misc/ss.c
> index 347e3a1..3a0d524 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -3411,11 +3411,11 @@ static void _usage(FILE *dest)
>  "   -F, --filter=FILE   read filter information from FILE\n"
>  "       FILTER := [ state STATE-FILTER ] [ EXPRESSION ]\n"
>  "       STATE-FILTER :=
> {all|connected|synchronized|bucket|big|TCP-STATES}\n"
> -"         TCP-STATES :=
> {established|syn-sent|syn-recv|fin-wait-{1,2}|time-wait|closed|close-wait|la
> st-ack|listen|closing}\n"
> +"         TCP-STATES :=
> {established|syn-sent|syn-recv|fin-wait-{1,2}|time-wait|closed|close-wait|la
> st-ack|listening|closing}\n"
>  "          connected :=
> {established|syn-sent|syn-recv|fin-wait-{1,2}|time-wait|close-wait|last-ack|
> closing}\n"
>  "       synchronized :=
> {established|syn-recv|fin-wait-{1,2}|time-wait|close-wait|last-ack|closing}\
> n"
>  "             bucket := {syn-recv|time-wait}\n"
> -"                big :=
> {established|syn-sent|fin-wait-{1,2}|closed|close-wait|last-ack|listen|closi
> ng}\n"
> +"                big :=
> {established|syn-sent|fin-wait-{1,2}|closed|close-wait|last-ack|listening|cl
> osing}\n"
>                 );
>  }

The patch has been corrupted by linewrapping in your mailer and therefore
can not be applied. Please figure out how to send a patch that does not
cause extra line breaks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html