netdev - Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150626150401.GH9469@lunn.ch>
Date:	Fri, 26 Jun 2015 17:04:01 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	giladb@...hip.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Gilad Ben-Yossef <gilad@...yossef.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Scott Feldman <sfeldma@...il.com>
Subject: Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error

On Thu, Jun 25, 2015 at 04:50:13PM +0300, giladb@...hip.com wrote:
> From: Gilad Ben-Yossef <gilad@...yossef.com>
> 
> DSA master netdev promiscuity counter was not being properly
> decremented on slave device open error path.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
> CC: Gilad Ben-Yossef <giladb@...hip.com>
> CC: David S. Miller <davem@...emloft.net>
> CC: Florian Fainelli <f.fainelli@...il.com>
> CC: Guenter Roeck <linux@...ck-us.net>
> CC: Andrew Lunn <andrew@...n.ch>
> CC: Scott Feldman <sfeldma@...il.com>

Hi Gilad

Acked-by: Andrew Lunn <andrew@...n.ch>

FYI: I grep'ed the whole kernel. This seems to be the only place 0 is
passed to dev_set_promiscuity(), i.e. the same bug is not present
anywhere else.

Thanks
	Andrew

> ---
>  net/dsa/slave.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 04ffad3..0917123 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -112,7 +112,7 @@ static int dsa_slave_open(struct net_device *dev)
>  
>  clear_promisc:
>  	if (dev->flags & IFF_PROMISC)
> -		dev_set_promiscuity(master, 0);
> +		dev_set_promiscuity(master, -1);
>  clear_allmulti:
>  	if (dev->flags & IFF_ALLMULTI)
>  		dev_set_allmulti(master, -1);
> -- 
> 1.7.1
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html