netdev - Re: [v2,4/9] fsl/fman: Add FMan MURAM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1435283949.4306.16.camel@freescale.com>
Date:	Thu, 25 Jun 2015 20:59:09 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	igal.liberman@...escale.com
CC:	netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	madalin.bucur@...escale.com, pebolle@...cali.nl
Subject: Re: [v2,4/9] fsl/fman: Add FMan MURAM support

On Wed, 2015-06-24 at 22:34 +0300, igal.liberman@...escale.com wrote:
> +     struct muram_info *p_muram;

No Hungarian notation.

> +void fm_muram_free(struct muram_info *p_muram)
> +{
> +     /* Destroy pool */
> +     gen_pool_destroy(p_muram->pool);
> +     /* Unmap memory */
> +     iounmap(p_muram->vbase);
> +     /* Free pointer */
> +     kfree(p_muram);
> +}

This type of commenting is not useful.

> +     memset_io((void __iomem *)vaddr, 0, (int)size);

Unnecessary cast of size.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html