netdev - Re: [PATCH net 1/1] tipc: purge backlog queue counters when broadcast link is reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 28 Jun 2015 16:43:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jon.maloy@...csson.com
Cc:	netdev@...r.kernel.org, paul.gortmaker@...driver.com,
	erik.hugne@...csson.com, ying.xue@...driver.com, maloy@...jonn.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net 1/1] tipc: purge backlog queue counters when
 broadcast link is reset

From: Jon Maloy <jon.maloy@...csson.com>
Date: Sun, 28 Jun 2015 09:44:44 -0400

> In commit 1f66d161ab3d8b518903fa6c3f9c1f48d6919e74
> ("tipc: introduce starvation free send algorithm")
> we introduced a counter per priority level for buffers
> in the link backlog queue. We also introduced a new
> function tipc_link_purge_backlog(), to reset these
> counters to zero when the link is reset.
> 
> Unfortunately, we missed to call this function when
> the broadcast link is reset, with the result that the
> values of these counters might be permanently skewed
> when new nodes are attached. This may in the worst case
> lead to permananent, but spurious, broadcast link
> congestion, where no broadcast packets can be sent at
> all.
> 
> We fix this bug with this commit.
> 
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html