netdev - Re: [v2,8/9] fsl/fman: Add FMan Port Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1435478936.9432.29.camel@freescale.com>
Date:	Sun, 28 Jun 2015 03:08:56 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Liberman Igal-B31950 <Igal.Liberman@...escale.com>
CC:	Paul Bolle <pebolle@...cali.nl>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	Bucur Madalin-Cristian-B32716 <madalin.bucur@...escale.com>
Subject: Re: [v2,8/9] fsl/fman: Add FMan Port Support

Why are these two parts being submitted separately?  Worse, the CC list seems 
to be different for each part as I'm not seeing the "DPAA ETH driver".

-Scott

On Sun, 2015-06-28 at 03:06 -0500, Liberman Igal-B31950 wrote:
> Hi Paul,
> All those exported functions are used by DPAA ETH driver, which was 
> submitted by Bucur Madalin (only fm_port_get_buffer_time_stamp() is not 
> used currently, I'll remove it).
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Paul Bolle [mailto:pebolle@...cali.nl]
> > Sent: Friday, June 26, 2015 2:29 AM
> > To: Liberman Igal-B31950; netdev@...r.kernel.org
> > Cc: linuxppc-dev@...ts.ozlabs.org; Wood Scott-B07421; Bucur Madalin-
> > Cristian-B32716
> > Subject: Re: [v2,8/9] fsl/fman: Add FMan Port Support
> > 
> > On Wed, 2015-06-24 at 22:37 +0300,  igal.liberman@...escale.comwrote:
> > > --- a/drivers/net/ethernet/freescale/fman/fm_drv.c
> > > +++ b/drivers/net/ethernet/freescale/fman/fm_drv.c
> > 
> > > +struct fm_port_t *fm_port_drv_handle(const struct fm_port_drv_t
> > > +*port) {
> > > + return port->fm_port;
> > > +}
> > > +EXPORT_SYMBOL(fm_port_drv_handle);
> > 
> > I couldn't find any users of this function.
> > 
> > > +void fm_port_get_buff_layout_ext_params(struct fm_port_drv_t *port,
> > > +>        >       >       >       >       struct fm_port_params *params)
> > 
> > (Evolution 3.16 is a piece of ...).
> > 
> > > +{
> > > + params->data_align = 0;
> > > +}
> > > +EXPORT_SYMBOL(fm_port_get_buff_layout_ext_params);
> > 
> > Ditto.
> > 
> > > +int fm_get_tx_port_channel(struct fm_port_drv_t *port) {
> > > + return port->tx_ch;
> > > +}
> > > +EXPORT_SYMBOL(fm_get_tx_port_channel);
> > 
> > Ditto.
> > 
> > > --- /dev/null
> > > +++ b/drivers/net/ethernet/freescale/fman/fm_port_drv.c
> > 
> > > +void fm_set_rx_port_params(struct fm_port_drv_t *port,
> > > +                    struct fm_port_params *params)
> > > +{
> > +   [...]
> > > +}
> > > +EXPORT_SYMBOL(fm_set_rx_port_params);
> > 
> > Ditto.
> > 
> > (If you hear about my arrest for randomly attacking innocent people:
> > blame evolution 3.16!)
> > 
> > > +void fm_set_tx_port_params(struct fm_port_drv_t *port,
> > > +                    struct fm_port_params *params)
> > > +{
> > > + [...]
> > > +}
> > > +EXPORT_SYMBOL(fm_set_tx_port_params);
> > 
> > Ditto.
> > 
> > > --- /dev/null
> > > +++ b/drivers/net/ethernet/freescale/fman/port/fm_port.c
> > 
> > > +u64 *fm_port_get_buffer_time_stamp(const struct fm_port_t
> > *p_fm_port,
> > > +                            char *p_data)
> > > +{
> > > + [...]
> > > +}
> > > +EXPORT_SYMBOL(fm_port_get_buffer_time_stamp);
> > 
> > Ditto.
> > 
> > > +int fm_port_disable(struct fm_port_t *p_fm_port) {
> > > + [...]
> > > +}
> > > +EXPORT_SYMBOL(fm_port_disable);
> > 
> > This exports a function that I think is only used inside this file.
> > 
> > > +int fm_port_enable(struct fm_port_t *p_fm_port) {
> > > + [...]
> > > +}
> > > +EXPORT_SYMBOL(fm_port_enable);
> > 
> > And here I could again find no users of this function.
> > 
> > Thanks,
> > 
> > 
> > Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html