netdev - Re: [PATCH] net: fec: don't access RACC register when not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150628.170251.1472757458531380273.davem@davemloft.net>
Date:	Sun, 28 Jun 2015 17:02:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerg@...inux.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: fec: don't access RACC register when not available

From: Greg Ungerer <gerg@...inux.org>
Date: Fri, 26 Jun 2015 15:10:35 +1000

> From 8969de63989b8814a6db9d00b9d1ceabe40e8b11 Mon Sep 17 00:00:00 2001
> From: Greg Ungerer <gerg@...inux.org>
> Date: Sat, 20 Jun 2015 15:51:57 +1000
> Subject: [PATCH] net: fec: don't access RACC register when not available
> 
> Not all silicon implementations of the Freescale FEC hardware module
> have the RACC (Receive Accelerator Function) register, so we should not
> be trying to access it on those that don't. Currently none of the ColdFire
> based parts with a FEC have it.
> 
> Support for RACC was introduced by commit 4c09eed9 ("net: fec: Enable imx6
> enet checksum acceleration"). A fix was introduced in commit d1391930
> ("net: fec: Fix build for MCF5272") that disables its use on the ColdFire
> M5272 part, but it doesn't fix the general case of other ColdFire parts.
> 
> To fix we create a quirk flag, FEC_QUIRK_HAS_RACC, and check it before
> working with the RACC register.
> 
> Signed-off-by: Greg Ungerer <gerg@...inux.org>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html