netdev - Re: [RFC PATCHv4] net: fec: Ensure clocks are enabled while using mdio bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150629034402.GA30187@lunn.ch>
Date:	Mon, 29 Jun 2015 05:44:02 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Duan Andy <fugang.duan@...escale.com>
Cc:	netdev <netdev@...r.kernel.org>,
	Cory Tusar <cory.tusar@...1solutions.com>
Subject: Re: [RFC PATCHv4] net: fec: Ensure clocks are enabled while using
 mdio bus

> > @@ -3496,10 +3523,11 @@ static int __maybe_unused fec_suspend(struct
> > device *dev)
> >  		netif_device_detach(ndev);
> >  		netif_tx_unlock_bh(ndev);
> >  		fec_stop(ndev);
> > -		fec_enet_clk_enable(ndev, false);
> >  		if (!(fep->wol_flag & FEC_WOL_FLAG_ENABLE))
> >  			pinctrl_pm_select_sleep_state(&fep->pdev->dev);
> >  	}
> > +
> > +	fec_enet_clk_enable(ndev, false);
> 
> Why do you move out the api from netif runnig condition ?

Ah, read the documentation again. I see my error. I thought it would
call fec_suspend() and fec_resume(). But now i see there are separate
runtime suspend and resume functions.

I will fix this.

  Andrew

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html