netdev - Re: [PATCH net] uapi: fix compatability of linux/in.h with netinet/in.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150629145548.4169cf9d@uryu.home.lan>
Date:	Mon, 29 Jun 2015 14:55:48 -1000
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Pablo Neira Ayuso <pablo@...filter.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] uapi: fix compatability of linux/in.h with
 netinet/in.h

On Mon, 29 Jun 2015 20:07:20 +0200
Pablo Neira Ayuso <pablo@...filter.org> wrote:

> On Thu, Jun 25, 2015 at 11:12:06PM -0400, Stephen Hemminger wrote:
> > This fixes breakage to iproute2 build with recent kernel headers
> > caused by:
> >    commit a263653ed798216c0069922d7b5237ca49436007
> >    Author: Pablo Neira Ayuso <pablo@...filter.org>
> >    Date:   Wed Jun 17 10:28:27 2015 -0500
> > 
> >    netfilter: don't pull include/linux/netfilter.h from netns headers
> > 
> > The issue is that definitions in linux/in.h overlap with those
> > in netinet/in.h. This patch solves this by introducing the same
> > mechanism as was used to solve the same problem with linux/in6.h
> 
> My patch also modifies non-exposed net/netns/ headers, I'm not sure
> how this can be causing problems to uapi headers.

The problem is that your patch changes include/uapi/linux/netfilter.h
to include linux/in.h. Some programs have already include <netinet/in.h>
(often through a complex chain of headers).
If both headers are included it causes errors and warnings about duplicate
definitions. My patch fixes that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html