netdev - Re: [PATCH net] sock_diag: don't broadcast kernel sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150630.100051.61087407377848348.davem@davemloft.net>
Date:	Tue, 30 Jun 2015 10:00:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kraig@...gle.com
Cc:	netdev@...r.kernel.org, davej@...emonkey.org.uk,
	edumazet@...gle.com, ebiederm@...ssion.com
Subject: Re: [PATCH net] sock_diag: don't broadcast kernel sockets

From: Craig Gallek <kraig@...gle.com>
Date: Tue, 30 Jun 2015 12:49:32 -0400

> Kernel sockets do not hold a reference for the network namespace to
> which they point.  Socket destruction broadcasting relies on the
> network namespace and will cause the splat below when a kernel socket
> is destroyed.
> 
> This fix simply ignores kernel sockets when they are destroyed.
 ...
> Tested:
>   Using a debug kernel while 'ss -E' is running:
>   ip netns add test-ns
>   ip netns delete test-ns
> 
> Fixes: eb4cb008529c sock_diag: define destruction multicast groups
> Fixes: 26abe14379f8 net: Modify sk_alloc to not reference count the
>   netns of kernel sockets.
> Reported-by: Dave Jones <davej@...emonkey.org.uk>
> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Signed-off-by: Craig Gallek <kraig@...gle.com>

APplied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html