netdev - Re: 4.1 regression in resizable hashtable tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150702123130.GA20843@pox.localdomain>
Date:	Thu, 2 Jul 2015 14:31:30 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Meelis Roos <mroos@...ux.ee>
Cc:	sparclinux@...r.kernel.org,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Daniel Borkmann <daniel@...earbox.net>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: 4.1 regression in resizable hashtable tests

On 07/01/15 at 01:21pm, Meelis Roos wrote:
> This is 4.1 on sparc64 - one of my boxes that happens to have most 
> runtime test left on from some debugging effort. In 4.0 it was fine, 4.1 
> gives this in dmesg:
> 
> [   31.898697] Running resizable hashtable tests...
> [   31.898915]   Adding 2048 keys
> [   31.952911]   Traversal complete: counted=17, nelems=2048, entries=2048
> [   31.953004] Test failed: Total count mismatch ^^^
> [   32.022676]   Traversal complete: counted=17, nelems=2048, entries=2048
> [   32.022788] Test failed: Total count mismatch ^^^
> [   32.022828]   Deleting 2048 keys

Thanks for the report. I think this is already fixed. Can you try with the
following commit:

commit 246b23a7695bd5a457aa51a36a948cce53d1d477
Author: Thomas Graf <tgraf@...g.ch>
Date:   Thu Apr 30 22:37:44 2015 +0000

    rhashtable-test: Use walker to test bucket statistics

    As resizes may continue to run in the background, use walker to
    ensure we see all entries. Also print the encountered number
    of rehashes queued up while traversing.

    This may lead to warnings due to entries being seen multiple
    times. We consider them non-fatal.

    Signed-off-by: Thomas Graf <tgraf@...g.ch>
    Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html