netdev - Re: [PATCH net] bridge: vlan: fix usage of vlan 0 and 4095 again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55955CCF.4020106@gmail.com>
Date:	Fri, 03 Jul 2015 00:46:23 +0900
From:	Toshiaki Makita <toshiaki.makita1@...il.com>
To:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
CC:	netdev@...r.kernel.org, vyasevich@...il.com,
	bridge@...ts.linux-foundation.org, davem@...emloft.net,
	stephen@...workplumber.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH net] bridge: vlan: fix usage of vlan 0 and 4095 again

On 15/07/02 (木) 21:48, Nikolay Aleksandrov wrote:
> Vlan ids 0 and 4095 were disallowed by commit:
> 8adff41c3d25 ("bridge: Don't use VID 0 and 4095 in vlan filtering")
> but then the check was removed when vlan ranges were introduced by:
> bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")
> So reintroduce the vlan range check.
> Before patch:
> [root@...tvm ~]# bridge vlan add vid 0 dev eth0 master
> (succeeds)
> After Patch:
> [root@...tvm ~]# bridge vlan add vid 0 dev eth0 master
> RTNETLINK answers: Invalid argument
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> Fixes: bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")

Thank you for fixing this.

Acked-by: Toshiaki Makita <toshiaki.makita1@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html