netdev - Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1507022140100.1649@ja.home.ssi.bg>
Date:	Thu, 2 Jul 2015 21:47:31 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Alex Gartrell <alexgartrell@...il.com>
cc:	Eric Dumazet <edumazet@...gle.com>,
	David Miller <davem@...emloft.net>,
	"agartrell@...com" <agartrell@...com>,
	netdev <netdev@...r.kernel.org>, kernel-team <kernel-team@...com>
Subject: Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we
 have a TCP_TIMEWAIT sk


	Hello,

On Thu, 2 Jul 2015, Julian Anastasov wrote:

> 	Alex, in our discussion on January I thought
> we can skip calling skb_orphan for some cases but as
> input and output path use different skb->destructor
> we should call skb_orphan for every method, in every
> case when skb->dev != NULL, even when we do not call
> LOCAL_OUT, i.e. when NF_ACCEPT is returned for traffic
> to local real server. We should not call it only for
> local socket (skb->dev == NULL).
> 
> 	I think, your patch from January is almost
> good:
> 
> http://archive.linuxvirtualserver.org/html/lvs-devel/2015-01/msg00014.html
> 
> 	Just add skb->dev check and we should be fine.

	Sorry, I overlooked the problem. Above is not
correct because we can avoid the skb_orphan call
when 'local' is true. ip_vs_nat_send_or_cont should
call skb_orphan even for local=true while for TUN
it should be before ip_vs_prepare_tunneled_skb.
All other methods should avoid skb_orphan if
local=true or skb->dev is NULL.

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html