netdev - [PATCH] ipv6: Make MLD packets to only be processed locally.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Jul 2015 05:08:02 +0000
From:	Angga <Hermin.Anggawijaya@...iedtelesis.co.nz>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Angga <Hermin.Anggawijaya@...iedtelesis.co.nz>
Subject: [PATCH] ipv6: Make MLD packets to only be processed locally.


Before commit daad151263cf334 ("ipv6: Make ipv6_is_mld() inline and use it
from ip6_mc_input()." MLD packets were only processed locally. After the
change, a copy of MLD packet goes through ip6_mr_input, causing
MRT6MSG_NOCACHE message to be generated to user space.

Make MLD packet only processed locally.

Fixes: daad151263cf334 ("ipv6: Make ipv6_is_mld() inline and use it from 
ip6_mc_input().")

Signed-off-by: Hermin Anggawijaya <hermin.anggawijaya@...iedtelesis.co.nz>
---

diff --git a/linux/net/ipv6/ip6_input.c.orig b/linux/net/ipv6/ip6_input.c
index f2e464e..57990c9 100644
--- a/linux/net/ipv6/ip6_input.c.orig
+++ b/linux/net/ipv6/ip6_input.c
@@ -331,10 +331,10 @@ int ip6_mc_input(struct sk_buff *skb)
                                 if (offset < 0)
                                         goto out;

-                               if (!ipv6_is_mld(skb, nexthdr, offset))
-                                       goto out;
+                               if (ipv6_is_mld(skb, nexthdr, offset))
+                                       deliver = true;

-                               deliver = true;
+                               goto out;
                         }
                         /* unknown RA - process it normally */
                 }