netdev - Summary lightweight tunnel discussion at NFWS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150703100023.GH26182@pox.localdomain>
Date:	Fri, 3 Jul 2015 12:00:23 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	ebiederm@...ssion.com, rshearma@...cade.com, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Summary lightweight tunnel discussion at NFWS

On 06/18/15 at 09:49pm, Roopa Prabhu wrote:
> +#ifdef CONFIG_LWTUNNEL
> +		if (fi->fib_nh->nh_lwtstate) {
> +			struct lwtunnel_state *lwtstate;
> +
> +			lwtstate = fi->fib_nh->nh_lwtstate;
> +			if (nla_put_u16(skb, RTA_ENCAP_TYPE, lwtstate->type))
> +				goto nla_put_failure;
> +			lwtunnel_fill_encap(skb, lwtstate);
> +		}
>  	}
> +#endif

Misplaced #endif ;-)

Other than that I managed to rebase my changes onto yours and it
looks clean.

Since we also discussed this a bit at NFWS, I'm enclosing a quick
summary:

 * Overall consensus that a lightweight flow based encapsulation
   makes sense.
 * Realization that what we actually want is stackable skb metadata
   between layers without over engineering it.
 * Consensus to avoid adding it to skb_shared_info and try to reuse
   the skb dst field.
 * New dst_metadata type similar to xfrm_dst which can carry metadata
   such as encapsulation instructions/information.
 * Can be made stackable to implement nested encapsulation if needed.
   Left out in the beginning to keep it simple.
 * Possible optimization option by putting the dst_metadata into a
   per cpu scratch buffer or stack without taking a reference and
   only force the reference & allocation when the skb is about to
   be queued. The regular fast path should never queue a skb with
   dst metadata attached.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html