netdev - RE: [PATCH net-next] net: macb: replace literal constant with NET_IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB5BCAC@AcuExch.aculab.com>
Date:	Fri, 3 Jul 2015 16:18:40 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Eric Dumazet' <eric.dumazet@...il.com>,
	Joe Perches <joe@...ches.com>
CC:	Nicolae Rosia <nicolae.rosia@...tsign.ro>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	'Nicolas Ferre <nicolas.ferre@...el.com>
Subject: RE: [PATCH net-next] net: macb: replace literal constant with
 NET_IP_ALIGN

From: Eric Dumazet
> Sent: 01 July 2015 23:14
> To: Joe Perches
...
> > > Then please use netdev_alloc_skb_ip_align(), so that you get rid of
> > > skb_reserve()
> >
> > It seems there are ~50 of these in the kernel tree
> > that could be converted.
> >
> 
> Make sure the 2 is really NET_IP_ALIGN
> 
> Some hardwares need 2, even if NET_IP_ALIGN is 0 (on x86 arches for
> example)

Even on x86 aligning the ethernet receive data on a 4n+2
boundary is likely to give marginally better performance
than aligning on a 4n boundary.

	David