netdev - Re: [RFC PATCH net-next] tcp: add NV congestion control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150703.093715.1504840554531952050.davem@davemloft.net>
Date:	Fri, 03 Jul 2015 09:37:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	brakmo@...com, netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [RFC PATCH net-next] tcp: add NV congestion control

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 03 Jul 2015 07:00:23 +0200

> tcp_skb_cb is currently 44 bytes, so even if you add one u32, it should
> not exceed cb[]

Please see sock_skb_cb, which consumes space in skb->cb[] in parallel
with things like tcp_skb_cb.  The usage of skb->cb[] therefore really
is 48 bytes and I'm sure the build time assertions triggered if
Lawrence added the new tcp_skb_cb member without first increasing it's
size.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html