netdev - Re: [RFC PATCH net-next] tcp: add NV congestion control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1435943418.11970.74.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 03 Jul 2015 19:10:18 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	brakmo@...com, netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [RFC PATCH net-next] tcp: add NV congestion control

On Fri, 2015-07-03 at 09:37 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 03 Jul 2015 07:00:23 +0200
> 
> > tcp_skb_cb is currently 44 bytes, so even if you add one u32, it should
> > not exceed cb[]
> 
> Please see sock_skb_cb, which consumes space in skb->cb[] in parallel
> with things like tcp_skb_cb.  The usage of skb->cb[] therefore really
> is 48 bytes and I'm sure the build time assertions triggered if
> Lawrence added the new tcp_skb_cb member without first increasing it's
> size.

Oh... this part is completely buggy then.
We should revert net/ipv4/tcp.c change added in commit 

 b4772ef879a8f7d8c56118c2ae5a296fcf6f81d2

    net: use common macro for assering skb->cb[] available size in
protocol families



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html