netdev - Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55999EA3.4010303@dev.mellanox.co.il>
Date:	Mon, 06 Jul 2015 00:16:19 +0300
From:	Ido Shamay <idos@....mellanox.co.il>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>
CC:	netdev <netdev@...r.kernel.org>, Amir Vadai <amirv@...lanox.com>,
	Ido Shamay <idos@...lanox.com>
Subject: Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

On 7/2/2015 2:24 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> Mellanox driver has the knowledge if rxhash is a L4 hash,
> if it receives a non fragmented TCP or UDP frame and
> NETIF_F_RXCSUM is enabled on netdev.
>
> ip_summed value is CHECKSUM_UNNECESSARY in this case.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Amir Vadai <amirv@...lanox.com>
> Cc: Ido Shamay <idos@...lanox.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_rx.c |    8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> index 7a4f20bb7fcb..12c65e1ad6a9 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> @@ -917,7 +917,9 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
>   			if (dev->features & NETIF_F_RXHASH)
>   				skb_set_hash(gro_skb,
>   					     be32_to_cpu(cqe->immed_rss_invalid),
> -					     PKT_HASH_TYPE_L3);
> +					     (ip_summed == CHECKSUM_UNNECESSARY) ?
> +						PKT_HASH_TYPE_L4 :
> +						PKT_HASH_TYPE_L3);
Thanks Eric,

We can have a relaxation of the condition  by looking only at TCP/UDP 
CQE indication (without check-sum indications)
This can cover us also when device rx-checksuming feature is off.
Do we want it or a correlation between check-sum and l4_hash is needed?

Ido
>   
>   			skb_record_rx_queue(gro_skb, cq->ring);
>   			skb_mark_napi_id(gro_skb, &cq->napi);
> @@ -963,7 +965,9 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
>   		if (dev->features & NETIF_F_RXHASH)
>   			skb_set_hash(skb,
>   				     be32_to_cpu(cqe->immed_rss_invalid),
> -				     PKT_HASH_TYPE_L3);
> +				     (ip_summed == CHECKSUM_UNNECESSARY) ?
> +					PKT_HASH_TYPE_L4 :
> +					PKT_HASH_TYPE_L3);
>   
>   		if ((be32_to_cpu(cqe->vlan_my_qpn) &
>   		    MLX4_CQE_VLAN_PRESENT_MASK) &&
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html