netdev - Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5599A558.4090709@dev.mellanox.co.il>
Date:	Mon, 06 Jul 2015 00:44:56 +0300
From:	Ido Shamay <idos@....mellanox.co.il>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Amir Vadai <amirv@...lanox.com>,
	Ido Shamay <idos@...lanox.com>
Subject: Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

On 7/6/2015 12:33 AM, Eric Dumazet wrote:
> On Mon, 2015-07-06 at 00:16 +0300, Ido Shamay wrote:
>
>> We can have a relaxation of the condition  by looking only at TCP/UDP
>> CQE indication (without check-sum indications)
>> This can cover us also when device rx-checksuming feature is off.
>> Do we want it or a correlation between check-sum and l4_hash is needed?
> I thought about that, but this was adding a more complex test in fast
> path.
>
> Not sure we should care here, as nobody would disable hardware checksum
> if they care about performance.
I agree, thank you Eric
Acked-by: Ido Shamay <idos@...lanox.com>
>
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html