netdev - Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <559A675B.80408@citrix.com>
Date:	Mon, 6 Jul 2015 12:32:43 +0100
From:	Julien Grall <julien.grall@...rix.com>
To:	Florian Westphal <fw@...len.de>
CC:	<wei.liu2@...rix.com>, <ian.campbell@...rix.com>,
	<netdev@...r.kernel.org>, <bridge@...ts.linux-foundation.org>,
	<linux-kernel@...r.kernel.org>, <stephen@...workplumber.org>,
	Bernhard Thaler <bernhard.thaler@...et.at>,
	<xen-devel@...ts.xenproject.org>, <davem@...emloft.net>,
	Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

On 06/07/15 12:19, Florian Westphal wrote:
> Julien Grall <julien.grall@...rix.com> wrote:
>> On 03/07/15 21:42, Florian Westphal wrote:
>>> I think it makes more sense to use __in6_dev_get() instead which doesn't
>>> take a reference.
>>
>> __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on
>> this code is very limited. Are we sure that one this lock is hold? At
>> first glance, I wasn't able to find one.
> 
> All netfilter hooks are rcu_read_locked via nf_hook_slow().

Ok. I will resend the patch with __in6_dev_get.

> BTW, netfilter patches should be sent to netfilter-devel@...r.kernel.org.

I used scripts/get_maintainer.pl which doesn't provide this mailing list
for net/bridge/br_netfilter*.c

Regards,

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html