netdev - Re: [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jul 2015 10:19:39 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Rob Herring <robh@...nel.org>
Cc:	netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG

2015-07-05 10:16 GMT-07:00 Rob Herring <robh@...nel.org>:
> On UML builds, mdio-mux-mmioreg.c fails to compile:
>
> drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>
> This is due to CONFIG_OF now being user selectable. Add a dependency on
> HAS_IOMEM to fix this.
>
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: David S. Miller <davem@...emloft.net>
> ---
>  drivers/net/phy/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index cf18940..cb86d7a 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -191,7 +191,7 @@ config MDIO_BUS_MUX_GPIO
>
>  config MDIO_BUS_MUX_MMIOREG
>         tristate "Support for MMIO device-controlled MDIO bus multiplexers"
> -       depends on OF_MDIO
> +       depends on OF_MDIO && HAS_IOMEM
>         select MDIO_BUS_MUX
>         help
>           This module provides a driver for MDIO bus multiplexers that
> --
> 2.1.0
>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html