netdev - Re: linux-4.2-rc1/samples/bpf/sockex3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150707191437.GA6040@Alexeis-MBP.westell.com>
Date:	Tue, 7 Jul 2015 12:14:38 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	David Binderman <dcb314@...mail.com>
Cc:	Alexei Starovoitov <ast@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ?

On Tue, Jul 07, 2015 at 11:27:55AM +0000, David Binderman wrote:
> Hello there,
> 
> [linux-4.2-rc1/samples/bpf/sockex3_kern.c:268]: (style) Expression '(X & 0xf0) == 0x4' is always false.
> 
> Source code is
> 
>    if ((verlen & 0xF0) == 4)
> 
> Maybe
> 
>    if ((verlen & 0xF0) == 0x40)

oops, yes. Could you please send a patch to fix it. Thx

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html