netdev - Re: [PATCH] freescale:Make the function gfar_configure_coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 21:53:17 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	davem@...emloft.net, claudiu.manoil@...escale.com,
	haokexin@...il.com, matei.pavaluca@...escale.com,
	jingchang.lu@...escale.com, tobias@...dekranz.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] freescale:Make the function
 gfar_configure_coalescing_all static

On Tue, Jul 07, 2015 at 03:49:33PM -0400, Nicholas Krause wrote:
> This makes the function gfar_configure_coalescing_all static
> and removes its function prototype from the header file, gianfar.h
really? Looking at the diffstat I dare to disagree.

> due to this function only ever being called in its definition and
> declaration file of gainfar.c.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/net/ethernet/freescale/gianfar.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html