netdev - RE: [PATCH] freescale:Make the function gfar_clean_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DM2PR03MB41469B75835295813DD174D9C910@DM2PR03MB414.namprd03.prod.outlook.com>
Date:	Wed, 8 Jul 2015 07:40:28 +0000
From:	Manoil Claudiu <claudiu.manoil@...escale.com>
To:	Nicholas Krause <xerofoify@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] freescale:Make the function gfar_clean_tx_ring static

> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@...il.com]
> Sent: Tuesday, July 07, 2015 11:01 PM
> To: davem@...emloft.net
> Cc: Manoil Claudiu-B08782; haokexin@...il.com;
> matei.pavaluca@...escale.com; u.kleine-koenig@...gutronix.de;
> jingchang.lu@...escale.com; tobias@...dekranz.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] freescale:Make the function gfar_clean_tx_ring static
> 

Thanks, but for the sake of consistency (and for easy git tracking)
patches for this eth driver start with "gianfar: [...]" in the subject.
I don't see the urgency of turning all the driver functions to static.
There is some value to having some key functions defined as global,
like for debugging reasons, it helps with profiling, etc.

Claudiu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html