netdev - Re: [PATCH net-next v2] ipv4: add support for linkdown sysctl to netconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559CF0D6.3090602@6wind.com>
Date:	Wed, 08 Jul 2015 11:43:50 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Andy Gospodarek <gospo@...ulusnetworks.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] ipv4: add support for linkdown sysctl to
 netconf

Le 07/07/2015 19:56, Andy Gospodarek a écrit :
> This kernel patch exports the value of the new
> ignore_routes_with_linkdown via netconf.
>
> v2: changes to notify userspace via netlink when sysctl values change
> and proposed for 'net' since this could be considered a bugfix
Hmm, commit title contains net-next, not net.

>
> Signed-off-by: Andy Gospodarek <gospo@...ulusnetworks.com>
> Suggested-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

> ---
> I realize two of these changes result in lines >80 chars, but this is to
> keep the coding-style used by the surrounding code.
>
> There are multiple ways to resolve this, but one would be to shorten the
> defines used for this feature as "IGNORE_ROUTES_WITH_LINKDOWN" is a
> mouthful.  I would propose dropping "_WITH_" from all the defines and
> have only "IGNORE_ROUTES_LINKDOWN" everywhere.  Doing this now in 'net'
Yes. Or even shorter: IGNORE_NH_LINKDOWN?

> would be ideal before a release happens and it cannot be changed.
Yes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html