netdev - Re: [PATCH 3/3] ipmr_free_table() should be called under taken rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <559D0D9A.6050401@virtuozzo.com>
Date:	Wed, 08 Jul 2015 14:46:34 +0300
From:	Vasily Averin <vvs@...tuozzo.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH 3/3] ipmr_free_table() should be called under taken rtnl_lock



On 08.07.2015 13:29, Vasily Averin wrote:
> On 07.07.2015 20:53, Vasily Averin wrote:
>> On 07.07.2015 20:30, Cong Wang wrote:
>>> On Tue, Jul 7, 2015 at 10:25 AM, Vasily Averin <vvs@...tuozzo.com> wrote:
>>>> On 07.07.2015 20:13, Cong Wang wrote:
>>>>> On Tue, Jul 7, 2015 at 8:53 AM, Vasily Averin <vvs@...tuozzo.com> wrote:
>>>>>> ipmr_free_table() calls unregister_netdevice_many() inside
>>>>>> and changes net_todo_list protected by rtnl_lock
>>>>>
>>>>> Did you see any real bug?
>>>>
>>>> No, it was result of manual code review.
>>>>
>>>>> ipmr_free_table() is called in failure path, in this case there is no
>>>>> device registered yet, so unregister should be just a nop?
>>>>
>>>> However may be it's better to mark this place for future anyway?
>>>
>>> Then add a comment there. ;)
>>
>> As you can see I'm not familiar with this code,
>> so I would like to ask you to do it. :)
> 
> Seems I've found a better idea:
> to add ASSERT_RTNL() into unregister_netdevice_many()

It was done already,
there is ASSERT_RTNL() in rollback_registered_many() called from unregister_netdevice_many().

Please drop this patch, seems it isn't required. 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html