netdev - Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1231604948.157146.1436475804451.JavaMail.zimbra@savoirfairelinux.com>
Date:	Thu, 9 Jul 2015 17:03:24 -0400 (EDT)
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	David <davem@...emloft.net>
Cc:	andrew@...n.ch, netdev <netdev@...r.kernel.org>, sfeldma@...il.com,
	jiri@...nulli.us, Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	kernel <kernel@...oirfairelinux.com>
Subject: Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table
 Unit

Hi David,

----- On Jul 9, 2015, at 2:01 PM, David davem@...emloft.net wrote:

> From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
> Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT)
> 
>> You're right. There's a single operation to clear the STU and VTU. I
>> will send a follow-up patch to send this command during the switch
>> setup.
> 
> Fix known bugs in the patch series, within the patch series, since it
> hasn't been merged yet.
> 
> Don't say "I'll fix this bug later", because we can fix it now.
> 
> Also as others have noted, this patch set creates an intermediate
> state where functionality is effectively broken.  So it is illogical
> to knowingly merge this patch series as-is.  You'll have to piece
> together all of the changes necessary such that the series is fully
> bisectable, which means at every patch along the way things function
> properly and do not break.

Dully noted.

Thank you,
-v
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html