netdev - Re: [patch iproute2] iproute2: ipa: show switch id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150709061125.GC2270@nanopsycho.orion>
Date:	Thu, 9 Jul 2015 08:11:25 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	David Ahern <dsahern@...il.com>
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [patch iproute2] iproute2: ipa: show switch id

Wed, Jul 08, 2015 at 11:29:42PM CEST, dsahern@...il.com wrote:
>On 7/8/15 9:08 AM, Jiri Pirko wrote:
>>We forgot to include this patch somehow. So do it now.
>>
>>Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>>---
>>  ip/ipaddress.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>>diff --git a/ip/ipaddress.c b/ip/ipaddress.c
>>index 85a81ba..b7b4e3e 100644
>>--- a/ip/ipaddress.c
>>+++ b/ip/ipaddress.c
>>@@ -688,6 +688,14 @@ int print_linkinfo(const struct sockaddr_nl *who,
>>  				      b1, sizeof(b1)));
>>  	}
>>
>>+	if (tb[IFLA_PHYS_SWITCH_ID]) {
>>+		SPRINT_BUF(b1);
>>+		fprintf(fp, "switchid %s ",
>>+			hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
>>+				      RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
>>+				      b1, sizeof(b1)));
>>+	}
>>+
>>  	if (tb[IFLA_OPERSTATE])
>>  		print_operstate(fp, rta_getattr_u8(tb[IFLA_OPERSTATE]));
>>
>>
>
>Do Stephen's comments about port-name apply here?
>   http://www.spinics.net/lists/netdev/msg322693.html
>
>I was wondering if this should go into -details output rather than the
>default.

I would like to have this in default. It is very important info for user
who has switch device. He should see this right away.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html