netdev - Re: [PATCH] team: set IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150709100727.GE2270@nanopsycho.orion>
Date:	Thu, 9 Jul 2015 12:07:27 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Jan Blunck <jblunck@...radead.org>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] team: set IFF_SLAVE on team ports

Thu, Jul 09, 2015 at 11:58:34AM CEST, jblunck@...radead.org wrote:
>The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to
>decide if it should start the address configuration. Since team ports
>shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking
>a port to the team master.

I don't want to use IFF_SLAVE in team. Other master-slave devices are
not using that as well, for example bridge, ovs, etc.

I think that this should be fixed in addrconf_notify. It should lookup
if there is a master on top and bail out in that case.


>
>Signed-off-by: Jan Blunck <jblunck@...radead.org>
>---
> drivers/net/team/team.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
>index daa054b..4cd02c8 100644
>--- a/drivers/net/team/team.c
>+++ b/drivers/net/team/team.c
>@@ -1086,6 +1086,7 @@ static int team_upper_dev_link(struct net_device *dev,
> 	err = netdev_master_upper_dev_link(port_dev, dev);
> 	if (err)
> 		return err;
>+	port_dev->flags |= IFF_SLAVE;
> 	port_dev->priv_flags |= IFF_TEAM_PORT;
> 	return 0;
> }
>@@ -1094,6 +1095,7 @@ static void team_upper_dev_unlink(struct net_device *dev,
> 				  struct net_device *port_dev)
> {
> 	netdev_upper_dev_unlink(port_dev, dev);
>+	port_dev->flags &= ~IFF_SLAVE;
> 	port_dev->priv_flags &= ~IFF_TEAM_PORT;
> }
> 
>-- 
>2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html