netdev - Re: [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559FF958.1020403@cumulusnetworks.com>
Date:	Fri, 10 Jul 2015 09:56:56 -0700
From:	roopa <roopa@...ulusnetworks.com>
To:	Thomas Graf <tgraf@...g.ch>
CC:	Eric Dumazet <eric.dumazet@...il.com>, rshearma@...cade.com,
	ebiederm@...ssion.com, hannes@...essinduktion.org,
	pshelar@...ira.com, jesse@...ira.com, davem@...emloft.net,
	daniel@...earbox.net, tom@...bertland.com, edumazet@...gle.com,
	jiri@...nulli.us, marcelo.leitner@...il.com,
	stephen@...workplumber.org, jpettit@...ira.com, kaber@...sh.net,
	netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap
 attributes

On 7/10/15, 9:54 AM, Thomas Graf wrote:
> On 07/10/15 at 05:36pm, Eric Dumazet wrote:
>> On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote:
>>> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>>
>>> +	if (oif)
>>> +		dev = __dev_get_by_index(net, oif);
>>> +	ret = lwtunnel_build_state(dev, encap_type,
>>> +				   encap, &lwtstate);
>>> +	if (!ret) {
>>> +		lwtunnel_state_get(lwtstate);
>>> +		ret = lwtunnel_cmp_encap(lwtstate, nh->nh_lwtstate);
>>> +		lwtunnel_state_put(lwtstate);
>>> +
>>> +		return ret;
>>
>> These _get()/_put() calls do not seem necessary, or buggy.
>>
>> If refcounting is needed the _get() should be done at the time lwstate
>> is fetched.
> I'll let Roopa comment but it seems like these can just be removed.
Agree, They do seem unnecessary here.  I will get rid of them. thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html