lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jul 2015 04:49:04 +0000 From: Vineet Gupta <Vineet.Gupta1@...opsys.com> To: Arend van Spriel <arend@...adcom.com>, Vineet Gupta <Vineet.Gupta1@...opsys.com>, Peter Zijlstra <peterz@...radead.org>, "Ingo Molnar" <mingo@...nel.org>, Arnd Bergmann <arnd@...db.de> CC: "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Brett Rudley <brudley@...adcom.com>, "Franky (Zhenhui) Lin" <frankyl@...adcom.com>, Hante Meuleman <meuleman@...adcom.com>, Kalle Valo <kvalo@...eaurora.org>, Pieter-Paul Giesberts <pieterpg@...adcom.com>, Daniel Kim <dekim@...adcom.com>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "brcm80211-dev-list@...adcom.com" <brcm80211-dev-list@...adcom.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive On Thursday 09 July 2015 11:55 PM, Arend van Spriel wrote: > On 07/09/2015 10:13 AM, Vineet Gupta wrote: >> > There's already a generic implementation so use that instead. > There is or there was? If there is now I am fine with this patch, but if > it already was there the author might have had a reason for adding a > local function and I would like to hear that reason. > atomic_orr() was introduced to this driver with 2014-03-06 5cbb9c285bdc brcmfmac: Use atomic functions for intstatus update. as it seems atomic_set_mask() was not available cross arch. And atomic_or() in generic code was indeed introduced after that 2014-04-23 560cb12a4080 locking,arch: Rewrite generic atomic support Hence likely the reason author went with home grown atomic_orr() -Vineet -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists